Skip to content

Rename trustee JSON fields and refresh v2 API fixtures#291

Merged
juankuquintana merged 1 commit into
mainfrom
change/trustee-api-fields
May 4, 2026
Merged

Rename trustee JSON fields and refresh v2 API fixtures#291
juankuquintana merged 1 commit into
mainfrom
change/trustee-api-fields

Conversation

@juankuquintana
Copy link
Copy Markdown
Contributor

@juankuquintana juankuquintana commented May 1, 2026

Belongs to https://github.com/dnsimple/dnsimple-business/issues/2641

Rename trustee JSON fields and refresh v2 API fixtures

🔍 QA

From the rake console

/**
 * From the repository root:
 *   1. npm install && npm run build
 *   2. node test_local.mjs
 */
import { DNSimple } from "./dist/lib/main.js";

const client = new DNSimple({
  accessToken: "dnsimpletest_a_FSYtfYn7p74jfPd3GBUUsnLoOXia8hkR",
  baseUrl: "http://api.localhost:5000",
});

const accountId = 2;
const registrantId = 1;
const tldName = "com";
const domainName = "asdf.com";
const newDomainName = "nodedomain";

const list = await client.tlds.listTlds();
for (const t of list.data) {
  console.log(
    `tld=${t.tld} trustee_service_enabled=${t.trustee_service_enabled} trustee_service_required=${t.trustee_service_required}`
  );
}

const tld = (await client.tlds.getTld(tldName)).data;
console.log(
  `tld=${tld.tld} trustee_service_enabled=${tld.trustee_service_enabled} trustee_service_required=${tld.trustee_service_required}`
);

const domain = (await client.domains.getDomain(accountId, domainName)).data;
console.log(`domain=${domain.name} trustee=${domain.trustee}`);

const prices = (await client.registrar.getDomainPrices(accountId, domainName))
  .data;
console.log(
  `prices domain=${prices.domain} trustee_price=${prices.trustee_price}`
);

const registration = (
  await client.registrar.registerDomain(accountId, `${newDomainName}.com`, {
    registrant_id: registrantId,
  })
).data;
console.log(
  `registration domain_id=${registration.domain_id} trustee=${registration.trustee}`
);

📋 Deployment Pre/Post tasks

:shipit: Deployment Verification

  • QAd

@juankuquintana juankuquintana self-assigned this May 1, 2026
@juankuquintana juankuquintana requested a review from lokst May 1, 2026 02:30
@juankuquintana juankuquintana merged commit b5aec2d into main May 4, 2026
8 checks passed
@juankuquintana juankuquintana deleted the change/trustee-api-fields branch May 4, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants