Add regression tests for SSE comment lines from OpenRouter#2359
Merged
dgageot merged 1 commit intodocker:mainfrom Apr 10, 2026
Merged
Conversation
dgageot
force-pushed
the
board/fix-for-docker-agent-issue-2349-a172981b
branch
from
143663f to
3030384
Compare
The OpenAI Go SDK (v3.30.0) already handles SSE comment lines correctly, so no code fix is needed. Add regression tests for both ChatCompletions and Responses API paths to ensure SSE comments (e.g. ': OPENROUTER PROCESSING') don't cause 'unexpected end of JSON input' errors. Closes docker#2349 Assisted-By: docker-agent
dgageot
force-pushed
the
board/fix-for-docker-agent-issue-2349-a172981b
branch
from
3030384 to
9915e4e
Compare
trungutt
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add regression tests confirming that SSE comment lines (e.g.
: OPENROUTER PROCESSING) from providers like OpenRouter do not cause streaming errors.Details
The OpenAI Go SDK (v3.30.0) already handles SSE comment lines correctly per the SSE specification, so no code fix is needed. The tests cover both the ChatCompletions and Responses API paths with a fake HTTP server that sends comment lines before data events.
Closes #2349