offload: version update#24680
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
craig-osterhout
added
status/review
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR cleanly updates the minimum Docker Desktop version requirement for Docker Offload from 4.65 to 4.68. The change is applied consistently in both locations:
- The troubleshooting documentation (
content/manuals/offload/troubleshoot.md) - The summary metadata (
data/summary.yaml)
The version numbers match, the YAML syntax is valid, and the markdown formatting is correct. No issues found.
| Docker Offload: | ||
| subscription: [Docker Offload] | ||
| requires: Docker Desktop 4.65 and later | ||
| requires: Docker Desktop 4.68 or later |
There was a problem hiding this comment.
Minor style inconsistency
This change updates the conjunction from "and later" to "or later". However, summary.yaml predominantly uses "and later" for version requirements (71 instances vs. only 2 instances of "or later").
For consistency within this file, consider using:
requires: Docker Desktop 4.68 and laterThis is a minor style issue and doesn't affect functionality.
2 participants
Description
Updated min version supported by Offload to 4.68 for nudge functionality.
Related issues or tickets
https://docker.slack.com/archives/C09ARNANZCJ/p1775759784277949?thread_ts=1775557490.573449&cid=C09ARNANZCJ
Reviews