Add step to add user to group#258
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Docker installation instructions by adding a step to include the current user in the docker group, ensuring non-root access to the Docker daemon. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a user complaint regarding Docker access after installation. It resolves this by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull Request Overview
Adds a missing post-install step to ensure users can access Docker without sudo by joining the docker group.
- Add user to docker group after install
- Improve README guidance for Docker permissions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request adds a necessary step to the Linux installation instructions, granting the user permissions to interact with the Docker daemon without sudo. This resolves a common issue for new users. My review includes a suggestion to add a note for the user on how to apply the new group membership, as this change is not reflected in the current shell session and can be a source of confusion.
A user complained they could not access docker after installation. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
A user complained they could not access docker after installation.
Summary by Sourcery
Documentation: