Skip to content

Add step to add user to group#258

Merged
ericcurtin merged 1 commit intomainfrom
usermode
Oct 20, 2025
Merged

Add step to add user to group#258
ericcurtin merged 1 commit intomainfrom
usermode

Conversation

@ericcurtin
Copy link
Copy Markdown
Contributor

@ericcurtin ericcurtin commented Oct 18, 2025

A user complained they could not access docker after installation.

Summary by Sourcery

Documentation:

  • Add a step in README to run 'sudo usermod -aG docker $USER' so users can access Docker without sudo

Copilot AI review requested due to automatic review settings October 18, 2025 11:21
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Oct 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Docker installation instructions by adding a step to include the current user in the docker group, ensuring non-root access to the Docker daemon.

File-Level Changes

Change Details Files
Documented user group assignment for Docker access
  • Added usermod command to add $USER to the docker group
  • Placed the new command within the installation code block
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a user complaint regarding Docker access after installation. It resolves this by updating the README.md file to include a critical command that adds the current user to the docker group, ensuring they have the necessary permissions to interact with the Docker daemon immediately after installation.

Highlights

  • Docker Permissions: Added a sudo usermod -aG docker $USER command to the README.md installation instructions. This step grants the current user permission to access the Docker daemon, resolving a common post-installation access issue.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a missing post-install step to ensure users can access Docker without sudo by joining the docker group.

  • Add user to docker group after install
  • Improve README guidance for Docker permissions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread README.md
Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a necessary step to the Linux installation instructions, granting the user permissions to interact with the Docker daemon without sudo. This resolves a common issue for new users. My review includes a suggestion to add a note for the user on how to apply the new group membership, as this change is not reflected in the current shell session and can be a source of confusion.

Comment thread README.md Outdated
A user complained they could not access docker after installation.

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin ericcurtin merged commit e9302fa into main Oct 20, 2025
5 checks passed
@ericcurtin ericcurtin deleted the usermode branch October 20, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants