Skip to content

Update roslyn to 5.8.0-1.26267.2 #9321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidwengier wants to merge 4 commits into
base: main
Choose a base branch
from
+12 −2
Open

Update roslyn to 5.8.0-1.26267.2 #9321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6d8176
Update Roslyn to 5.8.0-1.26267.2
davidwengier May 17, 2026
44b995a
Update changelog with PR number
davidwengier May 17, 2026
a984a7f
Apply suggestion from @davidwengier
davidwengier May 17, 2026
67e0d15
Clarify Roslyn update PR description
davidwengier May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/skills/update-roslyn-version/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ This will output a list of PRs in the format needed for the changelog:
* <PR title> (PR: [#<number>](https://github.com/dotnet/roslyn/pull/<number>))
```

Keep the raw output from `roslyn-tools pr-finder`; you'll use it unchanged in the pull request description in Step 10.

### Step 7: Update CHANGELOG.md

Add an entry to `CHANGELOG.md` under the current version section (e.g., `# 2.121.x`):
Expand All @@ -174,7 +176,7 @@ Note: Leave the PR number blank initially (just `[#]`) - it will be updated afte

### Step 8: Filter Changelog Entries

Review the changelog entries and remove any PRs that obviously don't affect VS Code. Remove entries that are:
Review the changelog entries in `CHANGELOG.md` and remove any PRs that obviously don't affect VS Code. Remove entries that are:

- **Infrastructure/Build changes**: CI/CD pipelines, build scripts, Azure DevOps configurations
- **Visual Studio-only changes**: Features or fixes specific to Visual Studio IDE (not VS Code)
Expand Down Expand Up @@ -203,6 +205,7 @@ git push -u origin update/roslyn-<version>
Create a pull request on GitHub:
- Title: `Update roslyn to <new-version>`
- Base: `main`
- Description/body: the raw, unfiltered output from `roslyn-tools pr-finder` in Step 6, including the compare link and full PR list exactly as produced by the tool. Do not apply the Step 8 changelog filtering to the PR description.
Copy link
Copy Markdown
Member Author

@davidwengier davidwengier May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old update-razor-version skill used to do this, and personally I like that GitHub links up all of the PRs to the insertion, even if they're not in the change log. Let me know if you don't like it, and I can revert the changes to this file.

Copy link
Copy Markdown
Member

@dibarbet dibarbet May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm


### Step 11: Update Changelog with PR Number

Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)

# 2.143.x
* Update Roslyn to 5.8.0-1.26267.2 (PR: [#9321](https://github.com/dotnet/vscode-csharp/pull/9321))
* Fix racecondition on UnsuedDirectiveCache.Set (PR: [#83693](https://github.com/dotnet/roslyn/pull/83693))
* Fix single line script tag formatting (PR: [#83721](https://github.com/dotnet/roslyn/pull/83721))
* Implement type hierarchy LSP methods in Razor (PR: [#83637](https://github.com/dotnet/roslyn/pull/83637))
* Razor support for Implement Interface (PR: [#83636](https://github.com/dotnet/roslyn/pull/83636))
* Razor support for Implement Abstract Class (PR: [#83638](https://github.com/dotnet/roslyn/pull/83638))
* feat(LSP): add IsOptionServiceAvailable opt-in for CodeActionWithOptions filtering (PR: [#83650](https://github.com/dotnet/roslyn/pull/83650))

# 2.142.x
* Update Roslyn to 5.8.0-1.26262.9 (PR: [#9293](https://github.com/dotnet/vscode-csharp/pull/9293))
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"workspace"
],
"defaults": {
"roslyn": "5.8.0-1.26262.10",
"roslyn": "5.8.0-1.26267.2",
"omniSharp": "1.39.14",
"razorOmnisharp": "7.0.0-preview.23363.1",
"xamlTools": "18.7.11727.258"
Expand Down