Create ad blocking module with basic support for RC flags#8495
Create ad blocking module with basic support for RC flags#8495CrisBarreiro wants to merge 4 commits into
Conversation
013db12 to
a4b572c
Compare
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM
NIT: if api is empty, we don't need to create it. We can just have -impl for now.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f0a99e3. Configure here.
| fun self(): Toggle | ||
|
|
||
| @Toggle.DefaultValue(DefaultFeatureValue.FALSE) | ||
| fun enabledByDefault(): Toggle |
There was a problem hiding this comment.
Toggle named enabledByDefault defaults to FALSE
Medium Severity
The enabledByDefault() toggle is annotated with DefaultFeatureValue.FALSE, which contradicts its name. The codebase's own test fixture in FeatureTogglesTest establishes the convention that enabledByDefault() maps to DefaultFeatureValue.TRUE and disableByDefault() maps to DefaultFeatureValue.FALSE. If the intent is for this sub-feature to be off until RC enables it, the name is misleading and will confuse future readers; if the intent matches the name, the default value is wrong.
Please tell me if this was useful or not with a 👍 or 👎.
Reviewed by Cursor Bugbot for commit f0a99e3. Configure here.



Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1214489465023870?focus=true
Description
Add module and RC support for ad blocking
Steps to test this PR
n/a
UI changes
n/a
Note
Low Risk
Low risk: this PR only scaffolds a new module and defines remote feature flags/data models, with no runtime wiring or behavior changes shown beyond adding new buildable sources.
Overview
Adds a new
ad-blocking-implAndroid library module wired for DI (anvil/ksp) and depends onfeature-toggles-api/browser-api.Introduces
AdBlockingExtensionFeatureas a@ContributesRemoteFeaturewith two RC-backed toggles (selfandenabledByDefault, both defaulting to false) plus simple settings models (AdBlockingExtensionSettings,ScriptletEntry).Adds a minimal
ad-blocking/readme.mddescribing the feature and linking to design docs.Reviewed by Cursor Bugbot for commit f0a99e3. Bugbot is set up for automated code reviews on this repo. Configure here.