Validate TCP message string lengths#1746
Merged
kevinherron merged 1 commit intoMay 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
HelloMessage: validate constructor using UTF-8 encoded byte length, encode endpoint URL using UTF-8 byte length, and indecodereject negative lengths, enforceMAX_ENDPOINT_URL_LENGTH, and verify the declared length fits inbuffer.readableBytes()before allocating and reading bytes.ErrorMessage: encode reason using UTF-8 byte length, makedecodethrowUaException, reject negative lengths, enforce a message-size limit (EncodingLimits.DEFAULT_MAX_MESSAGE_SIZE), and verify remaining frame bytes before allocation.ErrorMessageTestand extendHelloMessageTestwith cases for negative lengths, truncated frames, and oversized lengths to cover the regression.throws UaException) where needed to propagate decoding errors.Codex Task