Fix role permission authorization checks#1749
Merged
kevinherron merged 2 commits intoMay 17, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/kevinherron/milo/sessions/72d88e37-d3c3-4ece-939e-b4e8473510fb Co-authored-by: kevinherron <340273+kevinherron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
UserRolePermissionsentry with a permission bit as sufficient, ignoring whether the entry’sroleIdwas assigned to the current session, which allowed role-based authorization bypasses.Description
UserRolePermissionsentry both has the requestedPermissionTypebit and that itsroleIdis present in the session’s mapped role IDs by adding a sharedhasPermission(...)helper and using it in all affected checks.Stream.anyMatch(rp -> rp.getPermissions().getX())checks withhasPermission(roleIds, ..., PermissionType::getX)across read/write RolePermissions,Historizing, browse, call, add reference, delete node, and delete reference paths inDefaultAccessController.PermissionTypeimport and aPredicate<PermissionType>-based helper to encapsulate the role-id match plus permission bit test inDefaultAccessController.checkRolePermissionAccess_DeniesPermissionsForUnassignedRolesto cover the mismatched-role scenarios across read, write, browse, call, add reference, delete node, and delete reference inDefaultAccessControllerTest.Codex Task