Preserve customizer handlers at pipeline head after handshake#1754
Merged
Conversation
UascClientAcknowledgeHandler.onAcknowledge previously called addFirst(messageHandler) on the channel pipeline, which displaced any handler installed at position 0 by the client's pipeline customizer (e.g. a PcapWriteHandler added via pipeline.addFirst). Because UascClientMessageHandler is a ByteToMessageCodec, it then consumed inbound ByteBufs before they could reach the displaced customizer handler — silently breaking pcap capture and similar use cases for the remainder of the session. Insert the message handler before DelegatingUascResponseHandler instead of at absolute position 0. The relative ordering is what the codec actually needs, and customizer handlers at the head keep seeing raw wire bytes — matching the symmetric behavior on the server side. Fixes #1740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UascClientAcknowledgeHandler.onAcknowledge previously called addFirst(messageHandler) on the channel pipeline, which displaced any handler installed at position 0 by the client's pipeline customizer (e.g. a PcapWriteHandler added via pipeline.addFirst). Because UascClientMessageHandler is a ByteToMessageCodec, it then consumed inbound ByteBufs before they could reach the displaced customizer handler — silently breaking pcap capture and similar use cases for the remainder of the session.
Insert the message handler before DelegatingUascResponseHandler instead of at absolute position 0. The relative ordering is what the codec actually needs, and customizer handlers at the head keep seeing raw wire bytes — matching the symmetric behavior on the server side.
Fixes #1740