fix: change auth:login to fall back to cookie auth#115
Open
wolfgangmm wants to merge 1 commit into
Open
Conversation
Contributor
|
this adds code that will be hopefully soon be dead code: when pb-login does the auth check in a different way. A unit test would be nice here. |
Member
|
@DrRataplan Yes, I also think we need to ensure the functionality for the next releases we need to keep this in. I can offer to create the test if @wolfgangmm does not have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the old behaviour of
auth:loginfor backwards compatibility with TP 10 and earlier:logoutto log out