fix(behavior): guard log_activity against unset logger#9
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7.
RPPortsarms GPIO Lick/Proximity callbacks in__init__, butBehavior.loggeris only set later inBehavior.setup(). A buffered edge between those two points fires the callback whileself.loggeris stillNone, andlog_activitycrashes onself.logger.logger_timer.elapsed_time()/self.logger.trial_key. RPi.GPIO swallows the exception on its C thread, the session continues, and the event is silently dropped.This guards the early-fire window: if
self.loggeris unset, log a warning and return the activity time without touchingself.logger.Type of change
How Has This Been Tested?
Added
test_log_activity_before_logger_setupintests/test_behavior.py. It setsbehavior.logger = Noneand assertslog_activityreturns the activity time instead of raisingAttributeError.Checklist: