[9.4](backport #6955) OpAMP redact slice maps#7008
Conversation
* OpAMP redact slice maps Redact slice maps with the form: - name: Authorization value: secretValue * update testing go.mod * Update notice * Fix test (cherry picked from commit 4d84c65) # Conflicts: # internal/pkg/api/handleOpAMP.go # internal/pkg/api/handleOpAMP_test.go
|
Cherry-pick of 4d84c65 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏 |
This comment has been minimized.
This comment has been minimized.
|
@copilot please fix the backport |
Agent-Logs-Url: https://github.com/elastic/fleet-server/sessions/7358a2d2-5ca3-4f38-beb1-f465528c67f2 Co-authored-by: michel-laterman <82832767+michel-laterman@users.noreply.github.com>
Fixed in |
This comment has been minimized.
This comment has been minimized.
TL;DRBoth failed Buildkite jobs for build https://buildkite.com/elastic/fleet-server/builds/14810 exited non-zero, but the provided logs are truncated and do not contain the actual failing test/error lines. The immediate next step is to rerun and capture full raw logs for Remediation
Investigation detailsRoot CauseThe root cause is not present in available artifacts. Both provided log files end with summary failure lines only, without the initiating failure record. Evidence
This pattern indicates the actionable failing frame is missing from the supplied excerpts. VerificationNot run in this workflow environment (analysis was limited to provided Buildkite failure artifacts and PR metadata). Follow-upOnce full logs are available, I can map the first failing stack/assertion directly to file/line and provide a concrete code fix. Note 🔒 Integrity filter blocked 1 itemThe following item were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
What is the problem this PR solves?
Redact slice maps with the form:
How does this PR solve the problem?
Use the shared redact package in elastic-agent-libs
How to test this PR locally
Enroll an opamp agent with sensitive values in the headers slices.
Design Checklist
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolRelated issues
This is an automatic backport of pull request OpAMP redact slice maps #6955 done by Mergify.