Fix Image.rotate.fit_to_fraction size mismatch#8067
Open
jsalort wants to merge 2 commits intoemilk:mainfrom
Open
Fix Image.rotate.fit_to_fraction size mismatch#8067jsalort wants to merge 2 commits intoemilk:mainfrom
jsalort wants to merge 2 commits intoemilk:mainfrom
Conversation
|
Preview is being built... Preview will be available at https://egui-pr-preview.github.io/pr/8067-CalcSizeRotate View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix to the clipped and wrong size when
fit_to_fractionis used on a rotated image. I think there are two issues:calc_sizeneeds to compute the ratio on the rotated box size, not the original box size;paint_texture_at, themesh.rotatemay yield negative and inconsistent origin, so I propose to add a translation to keep the top-left coordinate fixed.