RuboCop: resolve Style/StringLiterals issues

Author: orien

.rubocop_todo.yml

@@ -602,92 +602,6 @@ Style/StringConcatenation:
     - 'spec/stack_master/commands/compile_spec.rb'
     - 'spec/stack_master/template_utils_spec.rb'
 
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Exclude:
-    - 'Rakefile'
-    - 'bin/stack_master'
-    - 'example/simple/templates/myapp_vpc.rb'
-    - 'example/simple/templates/myapp_web.rb'
-    - 'features/step_definitions/parameter_store_steps.rb'
-    - 'features/support/env.rb'
-    - 'lib/stack_master.rb'
-    - 'lib/stack_master/aws_driver/s3.rb'
-    - 'lib/stack_master/change_set.rb'
-    - 'lib/stack_master/cli.rb'
-    - 'lib/stack_master/commands/apply.rb'
-    - 'lib/stack_master/commands/delete.rb'
-    - 'lib/stack_master/commands/drift.rb'
-    - 'lib/stack_master/commands/init.rb'
-    - 'lib/stack_master/commands/lint.rb'
-    - 'lib/stack_master/commands/status.rb'
-    - 'lib/stack_master/commands/terminal_helper.rb'
-    - 'lib/stack_master/commands/tidy.rb'
-    - 'lib/stack_master/config.rb'
-    - 'lib/stack_master/diff.rb'
-    - 'lib/stack_master/parameter_resolvers/latest_ami_by_tags.rb'
-    - 'lib/stack_master/parameter_resolvers/latest_container.rb'
-    - 'lib/stack_master/parameter_resolvers/one_password.rb'
-    - 'lib/stack_master/prompter.rb'
-    - 'lib/stack_master/role_assumer.rb'
-    - 'lib/stack_master/security_group_finder.rb'
-    - 'lib/stack_master/sns_topic_finder.rb'
-    - 'lib/stack_master/stack_definition.rb'
-    - 'lib/stack_master/stack_differ.rb'
-    - 'lib/stack_master/validator.rb'
-    - 'lib/stack_master/version.rb'
-    - 'spec/fixtures/sparkle_pack_integration/my_sparkle_pack/lib/sparkleformation/dynamics/my_dynamic.rb'
-    - 'spec/fixtures/sparkle_pack_integration/my_sparkle_pack/lib/sparkleformation/templates/dynamics/local_dynamic.rb'
-    - 'spec/fixtures/templates/rb/cfndsl/sample-ctp-repeated.rb'
-    - 'spec/fixtures/templates/rb/cfndsl/sample-ctp.rb'
-    - 'spec/fixtures/templates/rb/cfndsl/sample.rb'
-    - 'spec/fixtures/templates/rb/sparkle_formation/templates/template.rb'
-    - 'spec/integration/drift_spec.rb'
-    - 'spec/spec_helper.rb'
-    - 'spec/stack_master/aws_driver/s3_spec.rb'
-    - 'spec/stack_master/commands/apply_spec.rb'
-    - 'spec/stack_master/commands/compile_spec.rb'
-    - 'spec/stack_master/commands/delete_spec.rb'
-    - 'spec/stack_master/commands/drift_spec.rb'
-    - 'spec/stack_master/commands/init_spec.rb'
-    - 'spec/stack_master/commands/lint_spec.rb'
-    - 'spec/stack_master/commands/nag_spec.rb'
-    - 'spec/stack_master/commands/status_spec.rb'
-    - 'spec/stack_master/commands/validate_spec.rb'
-    - 'spec/stack_master/config_spec.rb'
-    - 'spec/stack_master/parameter_loader_spec.rb'
-    - 'spec/stack_master/parameter_resolver_spec.rb'
-    - 'spec/stack_master/parameter_resolvers/ami_finder_spec.rb'
-    - 'spec/stack_master/parameter_resolvers/ejson_spec.rb'
-    - 'spec/stack_master/parameter_resolvers/latest_container_spec.rb'
-    - 'spec/stack_master/parameter_resolvers/one_password_spec.rb'
-    - 'spec/stack_master/parameter_resolvers/parameter_store_spec.rb'
-    - 'spec/stack_master/parameter_resolvers/security_group_spec.rb'
-    - 'spec/stack_master/parameter_resolvers/security_groups_spec.rb'
-    - 'spec/stack_master/parameter_resolvers/stack_output_spec.rb'
-    - 'spec/stack_master/parameter_validator_spec.rb'
-    - 'spec/stack_master/security_group_finder_spec.rb'
-    - 'spec/stack_master/sparkle_formation/template_file_spec.rb'
-    - 'spec/stack_master/sso_group_id_finder_spec.rb'
-    - 'spec/stack_master/stack_definition_spec.rb'
-    - 'spec/stack_master/stack_differ_spec.rb'
-    - 'spec/stack_master/stack_events/presenter_spec.rb'
-    - 'spec/stack_master/stack_events/streamer_spec.rb'
-    - 'spec/stack_master/stack_spec.rb'
-    - 'spec/stack_master/template_compiler_spec.rb'
-    - 'spec/stack_master/template_compilers/cfndsl_spec.rb'
-    - 'spec/stack_master/template_compilers/json_spec.rb'
-    - 'spec/stack_master/template_compilers/sparkle_formation_spec.rb'
-    - 'spec/stack_master/template_utils_spec.rb'
-    - 'spec/stack_master/test_driver/cloud_formation_spec.rb'
-    - 'spec/stack_master/utils_spec.rb'
-    - 'spec/stack_master/validator_spec.rb'
-    - 'spec/stack_master_spec.rb'
-    - 'spec/support/aws_stubs.rb'
-    - 'stack_master.gemspec'
-
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
 # AllowedMethods: define_method

CHANGELOG.md

@@ -10,7 +10,12 @@ The format is based on [Keep a Changelog], and this project adheres to
 
 ## [Unreleased]
 
+### Changed
+
+- Resolve style issues identified by RuboCop ([#396])
+
 [Unreleased]: https://github.com/envato/stack_master/compare/v2.17.1...HEAD
+[#396]: https://github.com/envato/stack_master/pull/396
 
 ## [2.17.1] - 2025-12-19
 

Rakefile

@@ -1,4 +1,4 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'bundler/setup'
 
 task :environment do
@@ -19,7 +19,7 @@ begin
 
   require 'rspec/core/rake_task'
   RSpec::Core::RakeTask.new(:spec) do |t|
-    t.rspec_opts = "--format doc"
+    t.rspec_opts = '--format doc'
   end
 
   require 'rubocop/rake_task'

bin/stack_master

@@ -4,10 +4,10 @@ require 'stack_master'
 
 require 'stack_master/testing' if ENV['STUB_AWS'] == 'true'
 
-trap("SIGINT") { raise StackMaster::CtrlC }
+trap('SIGINT') { raise StackMaster::CtrlC }
 
 begin
   StackMaster::CLI.new(ARGV.dup).execute!
 rescue StackMaster::CtrlC
-  StackMaster.stdout.puts "Exiting..."
+  StackMaster.stdout.puts 'Exiting...'
 end

example/simple/templates/myapp_vpc.rb

@@ -1,5 +1,5 @@
 SparkleFormation.new(:myapp_vpc) do
-  description "A test VPC template"
+  description 'A test VPC template'
 
   resources.vpc do
     type 'AWS::EC2::VPC'

example/simple/templates/myapp_web.rb

@@ -1,5 +1,5 @@
 SparkleFormation.new(:myapp_web) do
-  description "Test web template"
+  description 'Test web template'
 
   parameters.vpc_id do
     description 'VPC ID'

features/step_definitions/parameter_store_steps.rb

@@ -6,7 +6,7 @@
         parameter: {
           name: parameter_name,
           value: parameter_value,
-          type: "SecureString",
+          type: 'SecureString',
           version: 1
         }
       }

features/support/env.rb

@@ -22,5 +22,5 @@
   Timecop.return
 end
 
-lib = File.join(File.dirname(__FILE__), "../../spec/fixtures/sparkle_pack_integration/my_sparkle_pack/lib")
+lib = File.join(File.dirname(__FILE__), '../../spec/fixtures/sparkle_pack_integration/my_sparkle_pack/lib')
 $LOAD_PATH << lib

lib/stack_master.rb

@@ -172,7 +172,7 @@ def skip_account_check?
   @non_interactive_answer = 'y'
 
   def base_dir
-    File.expand_path(File.join(File.dirname(__FILE__), ".."))
+    File.expand_path(File.join(File.dirname(__FILE__), '..'))
   end
 
   def cloud_formation_driver

lib/stack_master/aws_driver/s3.rb

@@ -28,15 +28,15 @@ def upload_files(bucket: nil, prefix: nil, region: nil, files: {})
           h.merge(obj.key => obj)
         end
 
-        StackMaster.stdout.puts "Uploading files to S3:"
+        StackMaster.stdout.puts 'Uploading files to S3:'
 
         files.each do |template, file|
           body = file.fetch(:body)
           path = file.fetch(:path)
           object_key = template.dup
           object_key.prepend("#{prefix}/") if prefix
           compiled_template_md5 = Digest::MD5.hexdigest(body).to_s
-          s3_md5 = current_objects[object_key] ? current_objects[object_key].etag.gsub("\"", '') : nil
+          s3_md5 = current_objects[object_key] ? current_objects[object_key].etag.gsub('"', '') : nil
 
           next if compiled_template_md5 == s3_md5
 
@@ -51,14 +51,14 @@ def upload_files(bucket: nil, prefix: nil, region: nil, files: {})
               metadata: { md5: compiled_template_md5 }
             }
           )
-          StackMaster.stdout.puts "done."
+          StackMaster.stdout.puts 'done.'
         end
       end
 
       def url(bucket:, prefix:, region:, template:)
         if region == 'us-east-1'
-          ["https://s3.amazonaws.com", bucket, prefix, template].compact.join('/')
-        elsif region.start_with? "cn-"
+          ['https://s3.amazonaws.com', bucket, prefix, template].compact.join('/')
+        elsif region.start_with? 'cn-'
           ["https://s3.#{region}.amazonaws.com.cn", bucket, prefix, template].compact.join('/')
         else
           ["https://s3-#{region}.amazonaws.com", bucket, prefix, template].compact.join('/')