Merge pull request #396 from envato/RuboCop

RuboCop: resolve `Style/*` issues

Author: orien

.rubocop_todo.yml

@@ -10,7 +10,12 @@ The format is based on [Keep a Changelog], and this project adheres to
 
 ## [Unreleased]
 
+### Changed
+
+- Resolve style issues identified by RuboCop ([#396])
+
 [Unreleased]: https://github.com/envato/stack_master/compare/v2.17.1...HEAD
+[#396]: https://github.com/envato/stack_master/pull/396
 
 ## [2.17.1] - 2025-12-19
 

CHANGELOG.md

@@ -1,11 +1,11 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'bundler/setup'
 
 task :environment do
   require 'stack_master'
 end
 
-task :console => :environment do
+task console: :environment do
   require 'pry'
   binding.pry
 end
@@ -19,12 +19,12 @@ begin
 
   require 'rspec/core/rake_task'
   RSpec::Core::RakeTask.new(:spec) do |t|
-    t.rspec_opts = "--format doc"
+    t.rspec_opts = '--format doc'
   end
 
   require 'rubocop/rake_task'
   RuboCop::RakeTask.new('rubocop')
 rescue LoadError
 end
 
-task :default => [:features, :spec, :rubocop]
+task default: %i[features spec rubocop]

Rakefile

@@ -2,14 +2,12 @@
 
 require 'stack_master'
 
-if ENV['STUB_AWS'] == 'true'
-  require 'stack_master/testing'
-end
+require 'stack_master/testing' if ENV['STUB_AWS'] == 'true'
 
-trap("SIGINT") { raise StackMaster::CtrlC }
+trap('SIGINT') { raise StackMaster::CtrlC }
 
 begin
   StackMaster::CLI.new(ARGV.dup).execute!
 rescue StackMaster::CtrlC
-  StackMaster.stdout.puts "Exiting..."
+  StackMaster.stdout.puts 'Exiting...'
 end

bin/stack_master

@@ -1,5 +1,5 @@
 SparkleFormation.new(:myapp_vpc) do
-  description "A test VPC template"
+  description 'A test VPC template'
 
   resources.vpc do
     type 'AWS::EC2::VPC'

example/simple/templates/myapp_vpc.rb

@@ -1,5 +1,5 @@
 SparkleFormation.new(:myapp_web) do
-  description "Test web template"
+  description 'Test web template'
 
   parameters.vpc_id do
     description 'VPC ID'

example/simple/templates/myapp_web.rb

@@ -6,7 +6,7 @@
         parameter: {
           name: parameter_name,
           value: parameter_value,
-          type: "SecureString",
+          type: 'SecureString',
           version: 1
         }
       }

features/step_definitions/parameter_store_steps.rb

@@ -21,20 +21,18 @@
 end
 
 def extract_hash_from_kv_string(string)
-  string.to_s.split(',').inject({}) do |hash, kv|
+  string.to_s.split(',').each_with_object({}) do |kv, hash|
     key, value = kv.split('=')
     hash[key] = value
-    hash
   end
 end
 
 Given(/^I stub the following stacks:$/) do |table|
   table.hashes.each do |row|
     row.symbolize_keys!
     row[:parameters] = StackMaster::Utils.hash_to_aws_parameters(extract_hash_from_kv_string(row[:parameters]))
-    outputs = extract_hash_from_kv_string(row[:outputs]).inject([]) do |array, (k, v)|
+    outputs = extract_hash_from_kv_string(row[:outputs]).each_with_object([]) do |(k, v), array|
       array << OpenStruct.new(output_key: k, output_value: v)
-      array
     end
     row[:outputs] = outputs
     StackMaster.cloud_formation_driver.add_stack(row)

features/step_definitions/stack_steps.rb

@@ -22,5 +22,5 @@
   Timecop.return
 end
 
-lib = File.join(File.dirname(__FILE__), "../../spec/fixtures/sparkle_pack_integration/my_sparkle_pack/lib")
+lib = File.join(File.dirname(__FILE__), '../../spec/fixtures/sparkle_pack_integration/my_sparkle_pack/lib')
 $LOAD_PATH << lib

features/support/env.rb

@@ -172,7 +172,7 @@ def skip_account_check?
   @non_interactive_answer = 'y'
 
   def base_dir
-    File.expand_path(File.join(File.dirname(__FILE__), ".."))
+    File.expand_path(File.join(File.dirname(__FILE__), '..'))
   end
 
   def cloud_formation_driver