Skip to content

Add new percentile aggregator and tests for comparing it with Byzantine#1052

Open
mina5rovic wants to merge 5 commits intodevelopfrom
percentile-aggregation
Open

Add new percentile aggregator and tests for comparing it with Byzantine#1052
mina5rovic wants to merge 5 commits intodevelopfrom
percentile-aggregation

Conversation

@mina5rovic
Copy link
Copy Markdown
Collaborator

@mina5rovic mina5rovic commented Feb 18, 2026

Implementation of new percentile aggregator based on the previously implemented Byzantine (in previous version of disco). This one work faster and in some cases better than the Byzantine. Also implemented tests for comparing those two.

Changing Byzantine aggregator based on errors found in implementation while comparing them.

Copy link
Copy Markdown
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comparison is very useful, thanks!

I have a bunch of questions, mostly due to my superficial knowledge of the algorithms. Overall, we're often getting exact values like 1.0000 which seems a bit fishy. Also, the new aggregator seems worse than the old both time- and robustness-wise. I believe it should at least be more robust so there are maybe some bugs that slipped into the implementation?

Finally, could you add a memory test case to ensure that the implementation is currently doing garbage disposal of unused TF tensors? You can do so by running multiple rounds/aggregations and keeping track of the number of tensors allocated in memory (tf.memory()), which ideally should stay constant throughout the training. You can read more on memory management here.

@mina5rovic mina5rovic requested a review from JulienVig April 14, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants