db/seg: precompute mask in patternTable to match posTable#21016
Closed
benderrobert wants to merge 1 commit intoerigontech:mainfrom
Closed
db/seg: precompute mask in patternTable to match posTable#21016benderrobert wants to merge 1 commit intoerigontech:mainfrom
mask in patternTable to match posTable#21016benderrobert wants to merge 1 commit intoerigontech:mainfrom
Conversation
Add `mask uint16` to `patternTable` (mirroring `posTable:79`). Initialize in `allocTable`, use in `nextPattern()` loop instead of computing `(1<<bitLen)-1` per iteration.
Collaborator
|
currently patternTables using 1G ram inside erigon. Adding more fields there will increase ram usage. Speed benefits are also unclear |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves decompression hot-path performance in db/seg by precomputing the Huffman lookup mask for patternTable (similar to the existing posTable approach) and reusing it during pattern decoding.
Changes:
- Added
mask uint16topatternTableto cache(1<<bitLen)-1. - Initialized the mask once in
patternArena.allocTable. - Switched
Getter.nextPattern()to use the precomputed mask instead of recomputing it per loop iteration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Yeah after re bench in local, its not that optimize than I thought. Closed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
mask uint16topatternTable(mirroringposTable:79). Initialize inallocTable, use innextPattern()loop instead of computing(1<<bitLen)-1per iteration.