db/downloader: preserve writeFile error when cleanup runs#21040
Open
mk0walsk wants to merge 1 commit intoerigontech:mainfrom
Open
db/downloader: preserve writeFile error when cleanup runs#21040mk0walsk wants to merge 1 commit intoerigontech:mainfrom
mk0walsk wants to merge 1 commit intoerigontech:mainfrom
Conversation
AskAlexSharov
approved these changes
May 8, 2026
Collaborator
|
@anacrolix i think you need to change library api to make it compile-time impossible |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the original writeFile failure by joining cleanup removal errors with the existing err, preventing defer-time cleanup from masking earlier write or sync failures.