feat(test-benchmark): devnet-7 compatibility for stateful benchmark#2885
Open
LouisTsai-Csie wants to merge 7 commits into
Open
feat(test-benchmark): devnet-7 compatibility for stateful benchmark#2885LouisTsai-Csie wants to merge 7 commits into
LouisTsai-Csie wants to merge 7 commits into
Conversation
…hmark (ethereum#2771) * refactor: failing 8037 benchmark cases * refactor: auth tx limit * fix: linitng issue * chore: ignore local EIP-8037 notes in `markdownlint-cli2` Add `.markdownlint-cli2.yaml` with an `ignores` list for the `EIP8037_REMAINING_FAILURES.md`, `EIP8037_PORTED_STATIC_FAILURES.md`, and `EIP8037_IMPLEMENTATION.md` working notes at the repo root. * refactor: deploy contract gas limit accounting * fix: gas accounting * feat: add stub for new snapshot --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
LouisTsai-Csie
commented
May 20, 2026
Comment on lines
+647
to
+651
| gas_limit=( | ||
| intrinsic_calc(authorization_list_or_count=1) | ||
| + storage_init_code.gas_cost(fork) | ||
| + 500_000 | ||
| ), |
Collaborator
Author
There was a problem hiding this comment.
Remove the hardcoded gas limit, adjust to dynamic gas cost calculation and leave some buffer.
Collaborator
Author
There was a problem hiding this comment.
This applies to other changes within the file.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This is the branch for benchmarking on devnet-7. It should not be merged before the following issue being resolved:
Details of each commit:
NO_CACHEvariant, this commit remove all the other combination.0x111...111as initial pkey, but it is already occupied, update it to use a more random seed. Related PR feat: add extra withdrawal request for pre-funding NethermindEth/gas-benchmarks#146 could be found in gas-benchmarks.test_sstore_bloatedbenchmark to support eip-8037 state gas calculation.devnets/bal/7branch. These commits used for fixing the linting issue.For commit 765f607, 3c11409 and 8a911bb, they are already reviewed and merged into
devnets/bal/3. This PR cherry-picks them to make sure benchmark test implementation is up-to-date to the latest spec.Then the linting issue should be fixed, which is included in this PR #2884 , and then rebase this PR, review and merge.
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture