Skip to content

Fix dependency declaration in setup.py #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calchiwo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix dependency declaration in setup.py #98

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad8781b
Fix dependency declaration in setup.py
calchiwo Dec 24, 2025
dda05bf
Remove setup-time network and version logic
calchiwo Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@
import subprocess
import codecs
import os

try:
import requests
requests_installed = True
except ImportError:
requests_installed = False
import requests

#VERSION = '0.0.1'
# VERSION = (
Expand All @@ -17,9 +12,6 @@
# )

def get_pypi_version():
if not requests_installed:
print("Warning: 'requests' module is not installed. Using default version.")
return "0.0.1"
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
try:
response = requests.get("https://pypi.org/pypi/easyPythonpi/json")
data = response.json()
Expand Down Expand Up @@ -90,8 +82,10 @@ def get_version():
description=DESCRIPTION,
long_description_content_type="text/markdown",
packages=find_packages(),
install_requires=["numpy >= 1.19.5"] + (["requests >= 2.25.1"] if not requests_installed else []),
setup_requires=["requests >= 2.25.1"],
install_requires=[
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
"numpy>=1.19.5",
"requests>=2.25.1",
],
keywords=['python', 'sorting', 'beginners', 'sockets'],
classifiers=[
"Development Status :: 1 - Planning",
Expand Down
Loading