Implement operations module#500
Merged
Merged
Conversation
Introduces the bfabric.operations package with dataset and workunit operations, migrating logic from bfabric.experimental and adding new structured validation, transforms, and change-tracking layers.
leoschwarz
changed the title
Contributor
📝 "TODO" Changes DetectedSummary: ❌ 2 "TODO"s removed ❌ Removed "TODO"s (2)
This comment is automatically updated when "TODO" changes are detected. |
- create_workunit returns a metadata-only Workunit (client=None) to avoid leaking the write client's credentials into lazy reference resolution on the returned entity. Callers re-read via client.reader.read_id if needed. - bfabric-cli dataset update now mirrors dataset upload: csv/tsv/xlsx/parquet subcommands, shared forbidden_chars / warn_trailing_spaces validation, and the same preview-then-confirm flow. - update_custom_attributes copies entity.custom_attributes defensively before merging. - Clarify dataset_column_types deprecation shim (privatization, not just a move) and tighten the bfabric_save_csv2dataset removal note in the changelog. - Design doc: add per-domain variation paragraph on payload-vs-params bundling. create_dataset / update_dataset docstrings note the metadata-only return. - Micro fixes: dead elif in transforms, Field(default_factory=list) in DatasetChanges, min(value) in row-count validator, import ordering in register.py, future annotations in upload.py. - Tests: classname in fixtures, .uri smoke tests for both operations, regression test asserting create_workunit returns _client is None.
leoschwarz
added a commit
that referenced
this pull request
May 19, 2026
Wires `_save_annotations` to `bfabric.operations.dataset.create_dataset` (landed in #500) instead of leaving it as a NotImplementedError stub. Threads `workunit_definition` into the save path so the annotation dataset is attached to the right workunit/container. Tightens the annotation spec: adds an optional `name` field, defaults `IncludeResourceRef.anchor` to `""`, drops the unused `update_existing` from `IncludeDatasetRef`, and removes the `UpdateExisting` import (which had created an import cycle). Reintroduces `OutputsSpec.read_yaml` as a model-returning helper and switches `register_outputs` and `cmd_validate_outputs_spec` to it. Fixes a latent bug in `generate_output_table` where an empty `include_tables` list crashed `pl.concat`; now raises a clear error when both lists are empty. Tests: adds `TestSaveAnnotations` with three mock-client cases, covers `OutputsSpec.read_yaml` round-trip, updates the existing anchor expectation from None to "". "Update existing dataset" remains deferred — no `Workunit.output_dataset` field exists today, so locating a prior dataset needs its own design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.