Remove guava dependency#5
Open
trajano wants to merge 2 commits intofge:masterfrom
Open
Conversation
Copied some Guava clases in internal.guava package-info.java added to indicate what revision the code was copied from. Used existing JDK 6 APIs when possible.
Author
|
Fixes #4 |
|
I would likely be willing to accept something along these lines in https://github.com/java-json-tools/uri-template as a part of java-json-tools/jackson-coreutils#11, but I want to push back a bit on cloning the various Guava files if at all possible. Is this still something you're interested in pursuing? /cc @soberich @huggsboson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.