resolved comments

Author: Varun Rathore

src/main/java/com/google/firebase/remoteconfig/ParameterValue.java

@@ -448,7 +448,8 @@ ParameterValueResponse toParameterValueResponse() {
           .setExperimentValue(
               new ExperimentValueResponse()
                   .setExperimentId(this.experimentId)
-                  .setExperimentVariantValues(variantValueResponses));
+                  .setExperimentVariantValues(variantValueResponses)
+                  .setExposurePercent(this.exposurePercent));
     }
 
     @Override

src/main/java/com/google/firebase/remoteconfig/Template.java

@@ -60,7 +60,7 @@ public Template(String etag) {
     this((String) null);
   }
 
-  Template(@NonNull TemplateResponse templateResponse) {
+  Template(@NonNull TemplateResponse templateResponse) throws FirebaseRemoteConfigException {
     checkNotNull(templateResponse);
     this.parameters = new HashMap<>();
     this.conditions = new ArrayList<>();
@@ -86,6 +86,7 @@ public Template(String etag) {
     if (templateResponse.getVersion() != null) {
       this.version = new Version(templateResponse.getVersion());
     }
+    validateExperimentExposurePercents(this.parameters);
     this.etag = templateResponse.getEtag();
   }
 
@@ -278,4 +279,28 @@ public boolean equals(Object o) {
   public int hashCode() {
     return Objects.hash(etag, parameters, conditions, parameterGroups, version);
   }
+
+  private static void validateExperimentExposurePercents(Map<String, Parameter> parameters)
+      throws FirebaseRemoteConfigException {
+    if (parameters == null) {
+      return;
+    }
+    for (Map.Entry<String, Parameter> entry : parameters.entrySet()) {
+      Parameter parameter = entry.getValue();
+      if (parameter == null || parameter.getConditionalValues() == null) {
+        continue;
+      }
+      for (ParameterValue value : parameter.getConditionalValues().values()) {
+        if (value instanceof ParameterValue.ExperimentValue) {
+          double exposurePercent = ((ParameterValue.ExperimentValue) value).getExposurePercent();
+          // Validate range [0, 100] and finiteness
+          if (exposurePercent < 0 || exposurePercent > 100 || !Double.isFinite(exposurePercent)) {
+            throw new FirebaseRemoteConfigException(
+                ErrorCode.INVALID_ARGUMENT,
+                "Experiment exposure percent must be between 0 and 100 (" + entry.getKey() + ")");
+          }
+        }
+      }
+    }
+  }
 }

src/test/java/com/google/firebase/remoteconfig/ParameterValueTest.java

@@ -18,9 +18,12 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertTrue;
 
 import com.google.common.collect.ImmutableList;
 import com.google.firebase.remoteconfig.ParameterValue.ExperimentVariantValue;
+import com.google.firebase.remoteconfig.internal.TemplateResponse.ParameterValueResponse;
+
 import org.junit.Test;
 
 public class ParameterValueTest {
@@ -137,4 +140,20 @@ public void testEquality() {
     assertNotEquals(experimentValueOne, experimentValueThree);
     assertNotEquals(experimentValueOne, experimentValueFour);
   }
+
+    @Test
+  public void testExperimentValueWithZeroExposure() {
+    ParameterValue.ExperimentValue value = ParameterValue.ofExperiment(
+        "exp_0", ImmutableList.of(ExperimentVariantValue.of("v1", "foo")), 0.0);
+    
+    // Test Serialization
+    ParameterValueResponse response = value.toParameterValueResponse();
+    assertEquals(0.0, response.getExperimentValue().getExposurePercent(), 0.0);
+    
+    // Test Deserialization
+    ParameterValue fromResponse = ParameterValue.fromParameterValueResponse(response);
+    assertTrue(fromResponse instanceof ParameterValue.ExperimentValue);
+    assertEquals(0.0, ((ParameterValue.ExperimentValue) fromResponse).getExposurePercent(), 0.0);
+  }
+
 }

src/test/java/com/google/firebase/remoteconfig/TemplateTest.java

@@ -107,7 +107,7 @@ public void testConstructorWithETag() {
   }
 
   @Test(expected = NullPointerException.class)
-  public void testConstructorWithNullTemplateResponse() {
+  public void testConstructorWithNullTemplateResponse() throws FirebaseRemoteConfigException{
     new Template((TemplateResponse) null);
   }