Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements real-time streaming support for the Firebase Data Connect SDK by introducing a WebSocket-based transport layer and a new streaming protocol. It transitions the library from gRPC to a hybrid REST and WebSocket approach, managed by a routing transport. Feedback highlights critical issues regarding resource management, specifically the potential for leaked WebSocket connections and memory leaks from uncancelled subscriptions. Other recommendations include optimizing the expensive operation ID generation, ensuring consistency by making variables final, and adhering to style guidelines regarding function length and the use of the non-null assertion operator.
|
The test failures are due to some auth sdk errors. I'll need to rebase on main which has some auth sdk fixes. But didn't want to disturb the ongoing reviews. EDIT: |
* Initial Commit * Fix formatting and analyzer warnings * Fix tests and licenses * Denver feedback: var initialization best practice * sorted keys for id generation * Fix analyze info messages
* Handle disconnects and reconnects * Address gemini review comments * Reconnection logic * Fixes to reconnect on startup * Fix to decode binary data from server * Handle gemini feedback * Update rest_transport mocks with new windows provider sig
* debug logging and hardering * Hardening: ensure only one multicast stream controller is created in a ref * Handle cancellations * Formatting fix
This affects reconnects. Taking tech debt instead.
initialized as a lazy var that is used everywhere instead of computing always
aashishpatil-g
force-pushed
the
ap/pasta
branch
from
9008a27 to
0bfe1d5
Compare
stephenarosaj
left a comment
stephenarosaj
left a comment
There was a problem hiding this comment.
LGTM - requesting changes but really just looking for a few responses / ACK on some comments
4 participants
Implements streaming support in Firebase Data Connect for subscribe().