Skip to content

FDS Source: Make arguments to GAS_PHASE_OUTPUT optional#16289

Merged
mcgratta merged 4 commits into
firemodels:masterfrom
mcgratta:dump_overhaul
May 19, 2026
Merged

FDS Source: Make arguments to GAS_PHASE_OUTPUT optional#16289
mcgratta merged 4 commits into
firemodels:masterfrom
mcgratta:dump_overhaul

Conversation

@mcgratta
Copy link
Copy Markdown
Contributor

No description provided.

@mcgratta mcgratta merged commit 915702a into firemodels:master May 19, 2026
34 checks passed
@mcgratta mcgratta deleted the dump_overhaul branch May 19, 2026 13:50
@mcgratta
Copy link
Copy Markdown
Contributor Author

FYI -- this change moves many of the global variables in dump.f90 to the relavant subroutines. There are a few left to deal with, like DRY, but I want to make sure things are OK. I did run a local firebot on this before committing. Also, variables to GAS_PHASE_OUTPUTS are now optional, which cleans things up a bit.

Marcos, you might want to check calls from the GEOM routines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant