Skip to content

Fix --block-time flag being ignored due to SlotDurationMilliseconds precedence #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maoueh wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Fix --block-time flag being ignored due to SlotDurationMilliseconds precedence #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions playground/artifacts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,10 @@ func (b *ArtifactsBuilder) Build(out *output) error {
if err != nil {
return err
}
// UnmarshalConfig starts from mainnet defaults which has SlotDurationMilliseconds=12000.
// Since SlotDurationMillis() prefers SlotDurationMilliseconds over SecondsPerSlot when > 0,
// we must sync it with the desired block time or the configured SecondsPerSlot is ignored.
clConfig.SlotDurationMilliseconds = b.l1BlockTimeInSeconds * 1000
if err := params.SetActive(clConfig); err != nil {
return err
}
Expand Down