refactor: use geist txn table#11
Open
metalboyrick wants to merge 2 commits into
Open
Conversation
debuggingfuture
requested changes
Feb 14, 2025
| ...(method && { method }), | ||
| ...(type && { type: type.join(",") }), | ||
| }); | ||
| const endpoint = `https://base-sepolia.blockscout.com/api/v2/transactions?${queryString.toString()}`; |
Member
There was a problem hiding this comment.
for changes in this dmeo repo is relatives fine, but if we are able to get wagmi working, we should use tanstack query to avoid setIsLoading ?
for contributing back to upstream (geist dapp kit),
- I think it is hard to share same abstraction of params across data sources. e.g. here filter is not use by alchemy.
sharing txn object parsed from their responses might work to certain extent
fundamentally we might want totally separate hooks, e.g.
in wagmi we have watchContractEvent and watchAccount
Lets add type to indiciate too
- lets create / use existing util for blockscout endpoint on L66
Member
Author
There was a problem hiding this comment.
setIsLoading was a quick fix haha for the hack.
fundamentally we might want totally separate hooks, e.g.
in wagmi we have watchContractEvent and watchAccount
You mean hooks by data provider?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.