Refactor Large Class Abstract Manager#115
Open
coolhatharry wants to merge 4 commits intofreezy:masterfrom
Open
Refactor Large Class Abstract Manager#115coolhatharry wants to merge 4 commits intofreezy:masterfrom
coolhatharry wants to merge 4 commits intofreezy:masterfrom
Conversation
Added files to the .gitignore from the preferences that were created by Android Studio
- Extracted KEY_SORT attributes to a new class called SortPreferenceMedia - Removed Interface ISortableManager from the child classes of AbstractManager
- Removed Unnecessary method getSortOrder from AbstractManager
- Added new folder for patches - Documented a patchiest of changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a patchset for the refactoring in the patchset folder, here is a rundown:
[PATCH 0/3]
Therefore, we extracted Sort attributes and methods to a new class called SortPreferenceMedia.
[PATCH 1/3] Added Preferences For IDE to Ignore File
[PATCH 2/3] Refactored AbstractManager
PATCH 3/3] Removed Sort Methods From AbstractManager