Quality: URL pathname can be null, causing path.parse to throw in filesystem utils#39533
Open
Nam0101 wants to merge 1 commit intogatsbyjs:masterfrom
Conversation
… path.parse to throw in filesystem utils `getParsedPath` calls `path.parse(Url.parse(url).pathname)` without a null fallback. For malformed/edge URL inputs where `pathname` is `null`, `path.parse` throws a `TypeError`, which can crash callers like `getRemoteFileExtension`/`getRemoteFileName`. The TypeScript equivalent in `gatsby-core-utils` already guards this with `|| ''`, indicating this JS version is less safe. Affected files: utils.js Signed-off-by: Nguyen Van Nam <nam.nv205106@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
getParsedPathcallspath.parse(Url.parse(url).pathname)without a null fallback. For malformed/edge URL inputs wherepathnameisnull,path.parsethrows aTypeError, which can crash callers likegetRemoteFileExtension/getRemoteFileName. The TypeScript equivalent ingatsby-core-utilsalready guards this with|| '', indicating this JS version is less safe.Severity:
mediumFile:
packages/gatsby-source-filesystem/src/utils.jsSolution
Add a safe fallback when parsing the pathname:
function getParsedPath(url) {
return path.parse(Url.parse(url).pathname || ``)
}
Optionally, harden
getRemoteFileNameagainst malformed percent-encoding:export function getRemoteFileName(url) {
const name = getParsedPath(url).name
try {
return decodeURIComponent(name)
} catch {
return name
}
}
Changes
packages/gatsby-source-filesystem/src/utils.js(modified)Description
Documentation
Tests
Related Issues
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #39532