fix(gatsby-source-filesystem): guard against null pathname in getParsedPath#39535
Open
funsaized wants to merge 2 commits intogatsbyjs:masterfrom
Open
fix(gatsby-source-filesystem): guard against null pathname in getParsedPath#39535funsaized wants to merge 2 commits intogatsbyjs:masterfrom
funsaized wants to merge 2 commits intogatsbyjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39532
getParsedPathingatsby-source-filesystem/src/utils.jscallspath.parse(Url.parse(url).pathname)without a null fallback. For malformed or edge-case URL inputs whereUrl.parse(url).pathnamereturnsnull,path.parsethrows aTypeError, crashing callers likegetRemoteFileExtensionandgetRemoteFileName.Changes
|| ''fallback toUrl.parse(url).pathnameingetParsedPath, matching the existing guard in the TypeScript equivalent atgatsby-core-utils/src/filename-utils.ts(line 12)mailto:URLs no longer throwBefore
After