Skip to content

Enhancement: Add support for Pyload 0.5.0 using API keys#6520

Closed
GammaC0de wants to merge 3 commits intogethomepage:devfrom
GammaC0de:fixes/pyload-apikey
Closed

Enhancement: Add support for Pyload 0.5.0 using API keys#6520
GammaC0de wants to merge 3 commits intogethomepage:devfrom
GammaC0de:fixes/pyload-apikey

Conversation

@GammaC0de
Copy link
Copy Markdown

@GammaC0de GammaC0de commented Apr 5, 2026

Proposed change

Adds support for Pyload 0.5.0 recent changes for accessing API using API keys.

#6459

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have added or updated tests for new features and bug fixes (see testing).
  • If applicable, I have reviewed the feature / enhancement and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • In the description above I have disclosed the use of AI tools in the coding of this PR.

@github-actions github-actions Bot added documentation Improvements or additions to documentation feature labels Apr 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 24.13793% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.43%. Comparing base (6df1cfd) to head (28b4cc2).
⚠️ Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
src/widgets/pyload/proxy.js 24.13% 22 Missing ⚠️

❌ Your patch status has failed because the patch coverage (24.13%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6520      +/-   ##
==========================================
- Coverage   88.57%   88.43%   -0.14%     
==========================================
  Files         524      524              
  Lines       24981    25119     +138     
  Branches     2170     2170              
==========================================
+ Hits        22127    22215      +88     
- Misses       2745     2795      +50     
  Partials      109      109              
Flag Coverage Δ
shard-1 33.30% <0.00%> (+0.10%) ⬆️
shard-2 30.55% <0.00%> (-0.13%) ⬇️
shard-3 38.84% <0.00%> (-0.17%) ⬇️
shard-4 30.96% <24.13%> (-0.08%) ⬇️
vitest 88.41% <24.13%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/widgets/pyload/proxy.js 65.00% <24.13%> (-9.44%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this code is now 90% duplication with the only difference being the header, we wouldnt accept that. Also for a tiny PR please include test coverage. Let us know if youre able / willing to take care of this, of not Im happy to. Thanks

@GammaC0de
Copy link
Copy Markdown
Author

GammaC0de commented Apr 11, 2026

Hi,
I would be happy if you could continue this since i don't have enough skills to build homepage to test if it actually works.

pyload-ng v0.5.0b3.dev97 or above is required.

@shamoon
Copy link
Copy Markdown
Collaborator

shamoon commented Apr 12, 2026

Thanks, done in #6558

@shamoon shamoon closed this Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants