fix(#749): handle negative step values#802
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2183dc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
latin-panda
approved these changes
May 6, 2026
Collaborator
latin-panda
left a comment
There was a problem hiding this comment.
One small comment below, but approving now to unblock
Collaborator
|
I couldn't comment inline 🤷🏽♀️ pasting it here instead: Line 87: The flag looks odd to me. I'd prefer parsing here. const step = parseNumericStringAttribute(element, 'step');
const absStep = (step.startsWith('-') ? step.substring(1) : step) as NumericString;
return new this(start, end, absStep); |
Collaborator
Author
Yeah me too... but I also didn't like the cast. I've created a second function, which calls the assertion after the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #749
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Test written
Why is this the best possible solution? Were any other approaches considered?
This would've been much easier to do in the vue component but because it's a spec feature I think it's better to have it in the engine for all clients to benefit from.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed