Response refactorization

Author: carlosb1

app/mod_photos/controllers.py

@@ -4,6 +4,8 @@
 from app.data import db
 from app.mod_photos.models import Photo
 
+from factory_responses import FactoryResponse
+
 import uuid
 import os
 
@@ -17,16 +19,14 @@ def allowed_file(filename):
 
 @mod_photos.route('/photos',methods=['POST'])
 def photos():
+	responses = FactoryResponse()
 	app.logger.debug("Applying post photo...")
 
         data = None
         if request.method == 'POST':
 		file = request.files['file']
 		if file and not allowed_file(file.filename):
-            	    resp = jsonify()
-        	    resp.content_type='application/json'
-    		    resp.status_code = 202
-		    return resp
+		    return responses.new202()
 
 		extension = os.path.splitext(file.filename)[1]
 		f_name=str(uuid.uuid4()) + extension
@@ -37,13 +37,11 @@ def photos():
 		file.save(filepath)
                 data = {'filename':f_name}
         #TODO refactor to set up necessary methods to create responses
-        if data == None:
-            resp = jsonify()
-            resp.status_code = 200
-        else:
-            resp = jsonify(data)
-	    resp.status_code = 201
-	#TODO add diferent type of constructors
-        resp.content_type='application/json'
+        #TODO is it necessary to return 200 command
+	resp = None
+	if data == None:
+        	resp = responses.new200()
+	else:
+		resp = responses.new201(data)
         return resp
 

app/mod_photos/factory_responses.py

@@ -0,0 +1,21 @@
+from flask import jsonify, json
+#TODO add unit tests for this class
+class FactoryResponse(object):
+    def new201(self,data):
+        resp = jsonify(data)
+        resp.content_type="application/json"
+        resp.status_code=201
+        return resp
+
+    def new202(self):
+        resp = jsonify()
+        resp.content_type="application/json"
+        resp.status_code=202
+        return resp
+
+    def new200(self):
+        resp = jsonify()
+        resp.content_type="application/json"
+        resp.status_code=200
+        return resp
+

app/mod_photos/tests.py

@@ -5,13 +5,38 @@
 from app import app
 
 from .models import Photo
+from factory_responses import FactoryResponse
+
 
 
 class TestModelPhoto(BaseTestCase):
     def test_new_photo(self):
         photo = Photo('1','/test/photo.png')
         self.assertTrue(photo.uuid,'1')
         self.assertTrue(photo.filepath,'/test/photo.png')
+class TestFactoryResponses(BaseTestCase):
+	responses = None
+
+	@classmethod
+	def setUpClass(cls):
+		cls.responses = FactoryResponse()
+	@classmethod
+	def tearDownClass(cls):
+		cls.responses = None
+	def test_200_correct(self):
+		#TODO add respnse
+		resp=self.responses.new200()
+		self.assertTrue(resp.status_code==200)
+		self.assertTrue(resp.content_type=="application/json")
+	def test_201_correct(self):
+		empty_data = {}
+		resp=self.responses.new201(empty_data)
+		self.assertTrue(resp.status_code==201)
+		self.assertTrue(resp.content_type=="application/json")
+	def test_202_correct(self):
+		resp=self.responses.new202()
+		self.assertTrue(resp.status_code==202)
+		self.assertTrue(resp.content_type=="application/json")
 
 class TestPhotosViews(BaseTestCase):
     def test_post_photo_correct(self):
@@ -32,4 +57,4 @@ def post_photo_not_allowed_file(self):
 		#self.app.logger.debug(response.json)
 		#TODO add assert for correct response
 		self.assertTrue(response.status_code == 202)
-	    
+