[Node] Set requestPermission False If Using Default Permission Handler#1056
Open
MRayermannMSFT wants to merge 3 commits intomainfrom
Open
[Node] Set requestPermission False If Using Default Permission Handler#1056MRayermannMSFT wants to merge 3 commits intomainfrom
requestPermission False If Using Default Permission Handler#1056MRayermannMSFT wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Node.js SDK session-resume behavior so extensions that don’t explicitly install a permission handler can be detected by the CLI/security layer, by sending requestPermission: false when the default join-session handler is used.
Changes:
- Introduces a shared
defaultJoinSessionPermissionHandlerintypes.tsfor extension session joining. - Updates
joinSession()to use the shared default permission handler instead of a local definition. - Changes
session.resumeRPC params to setrequestPermissionbased on whether a real permission handler was provided.
Show a summary per file
| File | Description |
|---|---|
| nodejs/src/types.ts | Adds shared default permission handler used as the sentinel for “no explicit handler.” |
| nodejs/src/extension.ts | Switches joinSession() to use the shared default handler (removes local handler). |
| nodejs/src/client.ts | Sets requestPermission to false when the default join-session handler is in use. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for extensions security work. We want to detect if an extension is trying to setup a permission handler.