Clarify conflicting persistence instructions in /speckit.clarify#2154
Open
song-chaeyoung wants to merge 1 commit intogithub:mainfrom
Open
Clarify conflicting persistence instructions in /speckit.clarify#2154song-chaeyoung wants to merge 1 commit intogithub:mainfrom
song-chaeyoung wants to merge 1 commit intogithub:mainfrom
Conversation
Clarify that accepted answers are first recorded in working memory and then passed to the integration step below for per-integration persistence. This preserves the intended incremental-save flow while removing the conflict between step 4's earlier "do not yet write to disk" wording and step 5's instruction to save after each integration.
song-chaeyoung
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies /speckit.clarify persistence guidance so accepted answers are first captured in working memory, then immediately integrated and persisted per the existing “save after each integration” flow.
Changes:
- Updates step 4 wording to explicitly hand accepted answers to the integration step and persist after each integration, resolving a “do not yet write to disk” vs. “save after each integration” conflict.
Show a summary per file
| File | Description |
|---|---|
| templates/commands/clarify.md | Adjusts sequential questioning loop wording to align with incremental integration + per-answer disk persistence described in step 5. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify that accepted answers are first recorded in working memory and then passed to the integration step below for per-integration persistence.
This preserves the intended incremental-save flow while removing the conflict between step 4's earlier "do not yet write to disk" wording and step 5's instruction to save after each integration.
This PR is intentionally scoped to a single wording change in
templates/commands/clarify.md.Testing
uv run specify --helpuv sync --extra testanduv run python -m pytest tests/integrations/test_integration_codex.py tests/integrations/test_integration_generic.py tests/integrations/test_integration_copilot.py -qSample project check:
uv run specify init /tmp/spec-kit-clarify-8TOc7j/project --ai codex --offline --ignore-agent-tools.agents/skills/speckit-clarify/SKILL.mdincludes the updated persistence wordingAI Disclosure
I used AI assistance to review the conflicting wording, compare the repository's contribution and testing guidance, draft the wording update, and prepare the PR text. I reviewed the final change and test results manually.