Corrects linestyle change behaviour in scatter#524
Merged
astrofrog merged 7 commits intoglue-viz:mainfrom Mar 18, 2026
Merged
Conversation
astrofrog
reviewed
Mar 5, 2026
| vector_lines_cls = bqplot.Lines | ||
| self.vector_lines = vector_lines_cls(scales=self.view.scales, x=[0.], y=[0.]) | ||
| self.vector_lines.colors = [color2hex(self.state.color)] | ||
| self.vector_lines.color = [color2hex(self.state.color)] |
Member
There was a problem hiding this comment.
As we found before, Lines/LineGL doesn't have color I think?
Contributor
Author
There was a problem hiding this comment.
yeah i'm going to correct that next, i just want the tests building so I can check the issue @dhomeier has raised previously
Contributor
There was a problem hiding this comment.
Unless I missed something in that comment, they all inherit from Lines, which does have color, but that being an Array, not a List.
CyclingNinja
force-pushed
the
clean_vis_tests
branch
from
a34e5ec to
ea37d48
Compare
… all figure marks
astrofrog
approved these changes
Mar 18, 2026
Member
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
I pushed a few commits to fix the remaining issues. The visual test failures are for two of the UI tests which are unrelated to this PR but for which I need matplotlib/pytest-mpl#260 to ignore the flaky hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.