Skip to content

chore(deps): consolidate dependency and toolchain upgrades#1225

Merged
underfisk merged 9 commits into
masterfrom
copilot/close-open-prs-package-upgrade
May 20, 2026
Merged

chore(deps): consolidate dependency and toolchain upgrades#1225
underfisk merged 9 commits into
masterfrom
copilot/close-open-prs-package-upgrade

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 16, 2026

  • Triage the new PR comment
  • Identify open dependency PRs (dependabot/renovate) in golevelup/nestjs
  • Determine whether they can be closed via available automation tools
  • Take action where possible or provide clear unblock instructions
  • Reply to the new PR comment with outcome

Comment thread integration/google-cloud-pubsub/tsconfig.json Outdated
@underfisk underfisk marked this pull request as ready for review May 16, 2026 12:50
Copilot AI review requested due to automatic review settings May 16, 2026 12:50
Copilot AI requested a review from underfisk May 16, 2026 12:51
@underfisk
Copy link
Copy Markdown
Collaborator

@copilot Install dependencies is failing, pnpm v11 requires approveBuilds to be set therefore you'll have to set that on the pnpm workspace. Make sure that you run pnpm install on the new version and that it passes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates dependency and toolchain upgrades across the pnpm monorepo, including Node/pnpm tool versions, TypeScript, and several key runtime/test dependencies.

Changes:

  • Upgraded toolchain/runtime config (mise) and repository TypeScript configuration (incl. TS 6 deprecation handling).
  • Refreshed dependency versions and lockfile (TypeScript 6, Vitest, GraphQL, AWS SDK, @types/node).
  • Minor typing improvement in RabbitMQ connection getter.

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsconfig.spec.json Adds explicit node/jest types for Jest + ts-jest compilation.
tsconfig.json Adds TS deprecation suppression config and restricts ambient types to node.
pnpm-lock.yaml Lockfile refresh reflecting upgraded TypeScript/Vitest/GraphQL/AWS SDK dependency graph.
packages/testing/ts-jest/package.json Bumps AWS S3 client version used in the ts-jest testing package.
packages/rabbitmq/src/amqp/connection.ts Adds an explicit return type for managedChannels getter.
packages/graphql-request/package.json Bumps graphql dependency to ^16.14.0.
package.json Bumps TypeScript to 6.0.3, updates @types/node, and Vitest optional deps.
mise.toml Updates pinned Node and pnpm versions used by CI/local via mise.
integration/rabbitmq/tsconfig.json Adds ignoreDeprecations setting for TS 6 behavior.
integration/rabbitmq/package.json Bumps TypeScript to 6.0.3 for the RabbitMQ integration project.
integration/google-cloud-pubsub/tsconfig.json Adds ignoreDeprecations setting for TS 6 behavior.
integration/google-cloud-pubsub/package.json Bumps TypeScript to 6.0.3 for the Pub/Sub integration project.

Comment thread package.json Outdated
Comment thread integration/rabbitmq/package.json Outdated
Comment thread integration/google-cloud-pubsub/package.json Outdated
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 16, 2026

@copilot Install dependencies is failing, pnpm v11 requires approveBuilds to be set therefore you'll have to set that on the pnpm workspace. Make sure that you run pnpm install on the new version ...

Implemented in 84df34e: added pnpm workspace build-script approvals via allowBuilds in /home/runner/work/nestjs/nestjs/pnpm-workspace.yaml for the packages flagged in CI. I then ran pnpm v11.1.2 with Node v24.15.0 and pnpm install --prefer-offline now completes successfully.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • pnpm.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@underfisk
Copy link
Copy Markdown
Collaborator

@copilot Review the last CI run, it appears that sinon/some test types are not available to some of the libraries. It can be related to the typescript upgrade

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 20, 2026

@copilot Review the last CI run, it appears that sinon/some test types are not available to some of the libraries. It can be related to the typescript upgrade

Investigated the latest failed CI run (25962501394) and confirmed the typecheck failure was missing Jest globals in testing packages after the TS config changes. Fixed in b037a6c by explicitly setting "types": ["node", "jest"] in /home/runner/work/nestjs/nestjs/packages/testing/ts-jest/tsconfig.json and /home/runner/work/nestjs/nestjs/packages/testing/ts-sinon/tsconfig.json. Targeted checks now pass for @golevelup/ts-jest, @golevelup/ts-sinon, and @golevelup/ts-vitest.

"target": "es2020",
"sourceMap": true,
"outDir": "./dist",
"baseUrl": "./",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot is this still required the baseUrl removals?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not strictly required for TS 5.9.3, but keeping the baseUrl removals is still safe and keeps the integration tsconfigs compatible with TS 6 deprecation rules. They don’t change runtime behavior in this repo’s current import setup. No UI changes to screenshot for this config question.

@underfisk
Copy link
Copy Markdown
Collaborator

@copilot CI is failing on typecheck, run typecheck before commit and verify that all libraries compile just fine

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 20, 2026

@copilot Install dependencies is failing, pnpm v11 requires approveBuilds to be set therefore you'll have to set that on the pnpm workspace. Make sure that you run pnpm install on the new version ...

Addressed in 84df34e via workspace build-script approvals in /home/runner/work/nestjs/nestjs/pnpm-workspace.yaml. I rechecked with pnpm v11.1.2 and pnpm install --prefer-offline passes locally, and the latest CI run (26159902853) also shows Install dependencies succeeded. No UI changes to screenshot for this config-only update.

@copilot Review the last CI run, it appears that sinon/some test types are not available to some of the libraries. It can be related to the typescript upgrade

Checked the latest CI run (26159902853) and confirmed the failure was in @golevelup/nestjs-hasura:typecheck due to missing Jest globals in Hasura test files. Fixed in e7e6532 by adding "types": ["node", "jest"] to /home/runner/work/nestjs/nestjs/packages/hasura/tsconfig.json. This is a backend/config-only change, so there is no UI screenshot.

@underfisk
Copy link
Copy Markdown
Collaborator

@copilot Close all the open dependantbot/renovate PRs (dependencies) that this PR will address

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 20, 2026

@copilot CI is failing on typecheck, run typecheck before commit and verify that all libraries compile just fine

Verified on e7e6532: I re-ran CI-equivalent checks locally with pnpm v11.1.2 (pnpm build then pnpm lerna:typecheck) and all 13 libraries typecheck successfully. The latest CI run for this commit (26163210704) is also green. No UI changes, so no screenshot is applicable.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 20, 2026

@copilot Close all the open dependantbot/renovate PRs (dependencies) that this PR will address

I can’t directly close other PRs from this environment (the available GitHub tools here are read-only for PR state changes), but I verified this branch (e7e6532) supersedes these open Renovate dependency PRs: #1211 (Node 24.15.0), #1214 (pnpm), and #1209 (graphql 16.14.0). Please close those three from the GitHub UI; the remaining open Renovate PRs are for versions not included in this branch.

@underfisk underfisk merged commit 2d076e0 into master May 20, 2026
4 checks passed
@underfisk underfisk deleted the copilot/close-open-prs-package-upgrade branch May 20, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants