fix: Preserve Marketplace.Stubbed during client copy#4144
Merged
gmlewis merged 1 commit intogoogle:masterfrom Apr 10, 2026
Merged
fix: Preserve Marketplace.Stubbed during client copy#4144gmlewis merged 1 commit intogoogle:masterfrom
Marketplace.Stubbed during client copy#4144gmlewis merged 1 commit intogoogle:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4144 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 211 211
Lines 19685 19690 +5
=======================================
+ Hits 18453 18458 +5
Misses 1034 1034
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
changed the title
Marketplace.Stubbed during client copy
gmlewis
approved these changes
Apr 10, 2026
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode
munlicode
approved these changes
Apr 10, 2026
Contributor
|
LGTM |
Collaborator
|
Thank you, @munlicode! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
initialize.initializeandcopyalways replaceMarketplaceServicewith a fresh struct. This dropsMarketplaceService.Stubbedif it was previously set to true.