Skip to content

chore: Simplify redundantptr custom linter#4148

Merged
gmlewis merged 1 commit intogoogle:masterfrom
gmlewis:simplify-redundantptr
Apr 11, 2026
Merged

chore: Simplify redundantptr custom linter#4148
gmlewis merged 1 commit intogoogle:masterfrom
gmlewis:simplify-redundantptr

Conversation

@gmlewis
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis commented Apr 10, 2026

This reduces the maintenance burden for the redundantptr linter by removing an unnecessary fake file with the current version number built into its path.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.75%. Comparing base (7d06267) to head (e410ff3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4148      +/-   ##
==========================================
+ Coverage   93.70%   93.75%   +0.04%     
==========================================
  Files         210      211       +1     
  Lines       18996    19687     +691     
==========================================
+ Hits        17801    18458     +657     
- Misses       1009     1031      +22     
- Partials      186      198      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
Copy link
Copy Markdown
Collaborator Author

gmlewis commented Apr 10, 2026

@munlicode
Copy link
Copy Markdown
Contributor

LGTM,

Though I wonder, if comments should be left as they are?

_ = Ptr(name) // want `replace github.Ptr\(name\) with &name`

Is there a reason for leaving it this way?

@gmlewis
Copy link
Copy Markdown
Collaborator Author

gmlewis commented Apr 11, 2026

LGTM,

Though I wonder, if comments should be left as they are?

_ = Ptr(name) // want `replace github.Ptr\(name\) with &name`

Is there a reason for leaving it this way?

Yes, because it only flags the Ptr function in a "github" package.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 11, 2026
@gmlewis
Copy link
Copy Markdown
Collaborator Author

gmlewis commented Apr 11, 2026

Thank you, @munlicode and @alexandear!
Merging.

@gmlewis gmlewis merged commit f44402d into google:master Apr 11, 2026
8 checks passed
@gmlewis gmlewis deleted the simplify-redundantptr branch April 11, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants