chore: Simplify redundantptr custom linter#4148
Merged
gmlewis merged 1 commit intogoogle:masterfrom Apr 11, 2026
Merged
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4148 +/- ##
==========================================
+ Coverage 93.70% 93.75% +0.04%
==========================================
Files 210 211 +1
Lines 18996 19687 +691
==========================================
+ Hits 17801 18458 +657
- Misses 1009 1031 +22
- Partials 186 198 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode |
munlicode
approved these changes
Apr 11, 2026
Contributor
|
LGTM, Though I wonder, if comments should be left as they are? _ = Ptr(name) // want `replace github.Ptr\(name\) with &name`Is there a reason for leaving it this way? |
alexandear
approved these changes
Apr 11, 2026
Collaborator
Author
Yes, because it only flags the |
Collaborator
Author
|
Thank you, @munlicode and @alexandear! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the maintenance burden for the
redundantptrlinter by removing an unnecessary fake file with the current version number built into its path.