Delete stream configuration quick setting#511
Open
Kimblebee wants to merge 3 commits into
Open
Conversation
Deletes the stream configuration quick setting from the quick settings panel, as part of preparation for a quick settings UI refactor. The stream configuration setting remains available in the main settings screen.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the stream configuration setting from the quick settings panel and migrates its control to the main settings screen. This involves deleting StreamConfigUiState, removing setStreamConfig from the QuickSettingsController, and updating UI components and tests accordingly. A potential issue was identified in ConcurrentCameraTest.kt where navigating to the settings screen while the quick settings bottom sheet is open might cause the sheet to be dismissed, potentially leading to assertion failures for subsequent UI checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the stream configuration quick setting in anticipation of a quick settings UI refactor wherein it is removed. The stream configuration setting remains available in the main settings screen.