[codegen 1.5] Channel multiplexing fix: avoid scrambling valid conditions#4274
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
[codegen 1.5] Channel multiplexing fix: avoid scrambling valid conditions#4274copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…ions The logic for connecting the channel's valid and data signals has been moved outside the loop over individual send operations. This allows for a less wasteful/repetitive process for combining send operations - and fixes a bug in multiplexing channels! Previously, the `valid_conditions` vector was being repeatedly reversed in place before the next was added to the list, populating conditions in the order "...ECABDF..." and causing the wrong data to be sent! While we're at it, we also make sure the SourceInfo for the combined nodes is now an aggregate of all of the component Sends. PiperOrigin-RevId: 916197794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[codegen 1.5] Channel multiplexing fix: avoid scrambling valid conditions
The logic for connecting the channel's valid and data signals has been moved outside the loop over individual send operations. This allows for a less wasteful/repetitive process for combining send operations - and fixes a bug in multiplexing channels!
Previously, the
valid_conditionsvector was being repeatedly reversed in place before the next was added to the list, populating conditions in the order "...ECABDF..." and causing the wrong data to be sent!While we're at it, we also make sure the SourceInfo for the combined nodes is now an aggregate of all of the component Sends.