Skip to content

Commit 1456fb7

Browse files
committed
fixed test to use correct attribute
1 parent cc08308 commit 1456fb7

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpcTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
import com.google.cloud.NoCredentials;
4747
import com.google.cloud.bigquery.BigQueryOptions;
4848
import com.google.cloud.bigquery.telemetry.BigQueryTelemetryTracer;
49-
import com.google.cloud.bigquery.telemetry.HttpTracingRequestInitializer;
5049
import io.opentelemetry.api.common.AttributeKey;
5150
import io.opentelemetry.api.trace.Tracer;
5251
import io.opentelemetry.sdk.OpenTelemetrySdk;
@@ -947,7 +946,7 @@ public void testHttpTracingEnabledAddsAdditionalAttributes() throws Exception {
947946
.orElse(null);
948947
assertNotNull(rpcSpan);
949948
assertEquals("http", rpcSpan.getAttributes().get(BigQueryTelemetryTracer.RPC_SYSTEM_NAME));
950-
assertNotNull(rpcSpan.getAttributes().get(HttpTracingRequestInitializer.URL_DOMAIN));
949+
assertNotNull(rpcSpan.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_SERVICE));
951950
} finally {
952951
System.clearProperty("com.google.cloud.bigquery.http.tracing.dev.enabled");
953952
}
@@ -990,7 +989,7 @@ public void testHttpTracingDisabledDoesNotAddAdditionalAttributes() throws Excep
990989
.orElse(null);
991990
assertNotNull(rpcSpan);
992991
assertNull(rpcSpan.getAttributes().get(BigQueryTelemetryTracer.RPC_SYSTEM_NAME));
993-
assertNull(rpcSpan.getAttributes().get(HttpTracingRequestInitializer.URL_DOMAIN));
992+
assertNull(rpcSpan.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_SERVICE));
994993
} finally {
995994
System.clearProperty("com.google.cloud.bigquery.http.tracing.dev.enabled");
996995
}

0 commit comments

Comments
 (0)