chore(bq jdbc): fix docker environment commands#12107
Merged
Conversation
Contributor
Author
|
gemini /review |
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Docker and Makefile configurations to improve the build process within a monorepo structure. The main change is switching from copying a large number of files into the Docker context to cloning the repository directly within the Docker build, which is a good approach to speed up context transfer. The related changes in the Makefile and pom.xml are consistent with this new strategy. However, I found a critical issue in the Dockerfile where git is used but not installed, which will cause the build to fail. My review includes a suggested fix for this issue.
keshavdandeva
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make installto work in monorepogit clone. It makes it not suitable to validate cross-library changes, but vast majority of JDBC work is within JDBC folder.