feat: [appoptimize] new module for appoptimize#12756
Closed
cloud-java-bot wants to merge 1 commit intomainfrom
Closed
feat: [appoptimize] new module for appoptimize#12756cloud-java-bot wants to merge 1 commit intomainfrom
cloud-java-bot wants to merge 1 commit intomainfrom
Conversation
cloud-java-bot
added
the
owlbot:run
cloud-java-bot
added
the
owlbot:run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the configuration for the App Optimize API to the generation_config.yaml file. The feedback identifies a formatting inconsistency where the client_documentation URL is split across two lines and suggests moving it to a single line for better readability and consistency.
Comment on lines
+192
to
+193
| client_documentation: | ||
| https://cloud.google.com/java/docs/reference/google-cloud-appoptimize/latest/overview |
Contributor
There was a problem hiding this comment.
The client_documentation URL is split across two lines, which is inconsistent with other URL fields in this file (like product_documentation on line 188). While valid YAML, it's better to keep the URL on a single line for consistency and readability.
client_documentation: https://cloud.google.com/java/docs/reference/google-cloud-appoptimize/latest/overview
blakeli0
approved these changes
Apr 10, 2026
diegomarquezp
added a commit
that referenced
this pull request
Apr 10, 2026
Fixes the following failure occured in #12756 ([job](https://github.com/googleapis/google-cloud-java/actions/runs/24256669481/job/70829822721?pr=12756)): ``` YAMLException: end of the stream or a document separator is expected (24:1) 21 | 22 | deep-preserve-regex: 23 | - "/google-.*/src/test/java/co ... 24 | - "/.*google-.*/src/main/java/c ... ------^ 25 | 26 | deep-copy-regex: ``` The approach is to keep the indentation as 0 spaces before the dash. Added unit tests to confirm this. Also modified the yaml template to handle special cases such as `io/grafeas` instead of `com/google/cloud/service/...`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by @diegomarquezp via generate_new_client_hermetic_build.yaml
Command used: