fix(storage): add junit-vintage-engine to support native test discovery#13235
Open
nidhiii-27 wants to merge 6 commits into
Open
fix(storage): add junit-vintage-engine to support native test discovery#13235nidhiii-27 wants to merge 6 commits into
nidhiii-27 wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a 'native' profile to the pom.xml file for the gapic-google-cloud-storage-v2 module. This profile is configured to skip tests, with a note indicating that native testing for this specific module is handled within the google-cloud-storage module. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running native presubmit checks or building with the native profile, the builds for gapic-google-cloud-storage-v2 and google-cloud-storage-control fail with a
SurefireBooterForkException. The specific error indicates that the TestEngine with ID junit-vintage failed to discover tests.This failure occurs because:
maven-surefire-pluginto perform test discovery using the modern JUnit 5 Platform LauncherStorageClientTest.java) are standard JUnit 4 testsjunit-vintage-engineon the classpath to discover and execute these JUnit 4 testsThis PR fixes the discovery crash:
junit-vintage-engineas a test-scope dependency in bothgapic-google-cloud-storage-v2/pom.xmlandgoogle-cloud-storage-control/pom.xml