Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@
/*
* Copyright 2026 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.google.cloud.storage;

import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.trace.Span;
import io.opentelemetry.api.trace.SpanContext;
import io.opentelemetry.api.trace.StatusCode;
import java.util.concurrent.TimeUnit;

final class AcoSpan implements Span {
private final Span delegate;
private final String bucketName;
private final OtelStorageDecorator parent;

AcoSpan(Span delegate, String bucketName, OtelStorageDecorator parent) {
this.delegate = delegate;
this.bucketName = bucketName;
this.parent = parent;
}

private void applyCacheAttributes() {
if (bucketName != null && parent != null) {
BucketMetadataCache.BucketMetadata md = parent.bucketMetadataCache.get(bucketName);
if (md != null && !md.fetchPending) {
delegate.setAttribute("gcp.resource.destination.id", md.resource);
delegate.setAttribute("gcp.resource.destination.location", md.location);
Comment on lines +41 to +42
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When defining attribute keys, prefer using constants to avoid typos. However, ensure that gcp.client.artifact and gcp.client.version remain as hardcoded strings, as corresponding constants are not available in ObservabilityAttributes. Also, avoid using static final for constants that may need instance-level configuration in the future.

References
  1. Avoid declaring constants as 'static final' if there is a plan to expose or configure them at the instance level in the future.
  2. The attribute key gcp.client.artifact should be defined using a hardcoded string as a corresponding constant is not available in ObservabilityAttributes.
  3. The attribute key gcp.client.version should be defined using a hardcoded string as a corresponding constant is not available in ObservabilityAttributes.

}
}
}

@Override
public void end() {
applyCacheAttributes();
delegate.end();
}

@Override
public void end(long timestamp, TimeUnit unit) {
applyCacheAttributes();
delegate.end(timestamp, unit);
}

@Override
public Span recordException(Throwable exception) {
delegate.recordException(exception);
handleException(exception);
return this;
}

@Override
public Span recordException(Throwable exception, Attributes attributes) {
delegate.recordException(exception, attributes);
handleException(exception);
return this;
}

private void handleException(Throwable exception) {
if (exception instanceof StorageException && parent != null) {
StorageException se = (StorageException) exception;
if (se.getCode() == 404 && se.getMessage() != null) {
String msg = se.getMessage().toLowerCase(java.util.Locale.US);
if (msg.contains("bucket not found") || msg.contains("bucket does not exist")) {
parent.bucketMetadataCache.remove(bucketName);
}
}
}
}

@Override
public Span setAttribute(String k, String v) {
delegate.setAttribute(k, v);
return this;
}

@Override
public Span setAttribute(String k, long v) {
delegate.setAttribute(k, v);
return this;
}

@Override
public Span setAttribute(String k, double v) {
delegate.setAttribute(k, v);
return this;
}

@Override
public Span setAttribute(String k, boolean v) {
delegate.setAttribute(k, v);
return this;
}

@Override
public <T> Span setAttribute(AttributeKey<T> k, T v) {
delegate.setAttribute(k, v);
return this;
}

@Override
public Span addEvent(String n) {
delegate.addEvent(n);
return this;
}

@Override
public Span addEvent(String n, Attributes a) {
delegate.addEvent(n, a);
return this;
}

@Override
public Span addEvent(String n, long t, TimeUnit u) {
delegate.addEvent(n, t, u);
return this;
}

@Override
public Span addEvent(String n, Attributes a, long t, TimeUnit u) {
delegate.addEvent(n, a, t, u);
return this;
}

@Override
public Span setStatus(StatusCode c) {
delegate.setStatus(c);
return this;
}

@Override
public Span setStatus(StatusCode c, String d) {
delegate.setStatus(c, d);
return this;
}

@Override
public Span updateName(String name) {
delegate.updateName(name);
return this;
}

@Override
public SpanContext getSpanContext() {
return delegate.getSpanContext();
}

@Override
public boolean isRecording() {
return delegate.isRecording();
}
}
Loading
Loading