Add shader execution tests on the feature subgroup-size-control#4643
Open
Jiawei-Shao wants to merge 2 commits into
Open
Add shader execution tests on the feature subgroup-size-control#4643Jiawei-Shao wants to merge 2 commits into
subgroup-size-control#4643Jiawei-Shao wants to merge 2 commits into
Conversation
This patch adds the shader execution tests on the feature `subgroup-size-control`: - The value of the built-in variable `subgroup_size` must equal the value of the `@subgroup_size` attribute. - At least one value in the range of [GPUAdapterInfo.subgroupMinSize, GPUAdapterInfo.subgroupMaxSize] can be used as `@subgroup_size` attribute in a simple compute pipeline.
|
Results for build job (at 70e2921): +webgpu:shader,execution,shader_io,compute_builtins:subgroup_size_attribute:* - 6 cases, 6 subcases (~1/case)
+webgpu:shader,execution,shader_io,compute_builtins:subgroup_size_attribute_valid_size_exists:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 281256 cases, 2322907 subcases
+TOTAL: 281263 cases, 2322914 subcases |
Collaborator
Author
|
@kainino0x @jrprice PTAL, thanks! |
jrprice
reviewed
May 20, 2026
|
|
||
| g.test('subgroup_size_attribute') | ||
| .desc( | ||
| 'Tests that the value of the subgroup_size builtin must equal the value of the @subgroup_size attribute.' |
Contributor
There was a problem hiding this comment.
This test feels like just a subset of the test below, can we fold them together? i.e. for any pipeline that is successfully created in the below test, the value of the subgroup_size builtin should match the subgroup size attribute, and there must be at least one that succeeds.
That way we get better coverage of the fact that subgroup_size does actually change the subgroup size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the shader execution tests on the feature
subgroup-size-control:subgroup_sizemust equal the value of the@subgroup_sizeattribute.[subgroupMinSize, subgroupMaxSize]can be used as@subgroup_sizeattribute in a simple compute pipeline.
Issue: #4640
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.