Test viewFormats with TRANSIENT_ATTACHMENT#4647
Merged
Merged
Conversation
This should not be allowed. Issue: gpuweb/gpuweb#6263
Collaborator
Author
|
PTAL |
beaufortfrancois
approved these changes
May 21, 2026
kainino0x
added a commit
to gpuweb/gpuweb
that referenced
this pull request
May 21, 2026
Alternate option would be: allow `viewFormats` to be used, but it can only be exactly `[format]`. Tests: gpuweb/cts#4647 Fixes #6263
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
May 22, 2026
Without this, we hit "Failed to create MTLTexture view" in the Metal backend when trying to create a view with a different format on a transient texture. (This happens even without Metal validation layers so it's not a vulnerability, it just loses the device.) Bug: gpuweb/gpuweb#6263 Test: gpuweb/cts#4647 Change-Id: Ia4b33594b0d47822af34fc5d8294d22f996fdc38 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/310035 Reviewed-by: Fr <beaufort.francois@gmail.com> Commit-Queue: Fr <beaufort.francois@gmail.com> Auto-Submit: Kai Ninomiya <kainino@chromium.org>
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
May 22, 2026
https://dawn.googlesource.com/dawn.git/+log/e935a1b57eb8..86a5e62047fb 2026-05-22 jrprice@google.com [intrinsics] Use absolute paths for imports 2026-05-22 jrprice@google.com [bazel] Export .def and .tmpl files 2026-05-22 jrprice@google.com [bazel] Add BUILD.bazel files for Go packages 2026-05-22 jrprice@google.com Revert "[cmake] Add support for generated sources" 2026-05-22 petermcneeley@google.com [dawn] Add clang-tidy 'cppcoreguidelines-pro-type-member-init' 2026-05-22 jrprice@google.com Revert "[gn] Add support for generated sources" 2026-05-22 kainino@chromium.org [dawn][native] Disallow viewFormats with TRANSIENT_ATTACHMENT 2026-05-22 jiawei.shao@intel.com D3D12: Implement `GetAllocatorMemoryInfo()` 2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c61c0894e58c to e7a561a5f0b7 (200 revisions) 2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5e4cafd to 2976e22 (666 revisions) 2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 8c0d03247b35 to ac0a538752cb (3 revisions) 2026-05-22 senorblanco@chromium.org GL: unskip some BindGroup tests. 2026-05-22 jrprice@google.com [build] Add directory prefix to .tmpl file glob 2026-05-22 jrprice@google.com [build] Track includes to/from generated sources 2026-05-22 jrprice@google.com [gn] Add support for generated sources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com,rharrison@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-mac-arm64;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64 Bug: chromium:407730048,chromium:442860471,chromium:491082532,chromium:513255285 Tbr: rharrison@google.com Test: Test: gpuweb/cts#4647 Change-Id: I8e234fca2fbc2439d4a243dfe19febf04c97acfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7870967 Commit-Queue: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1635237}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be allowed.
Passes in Chromium with this patch: https://dawn-review.googlesource.com/c/dawn/+/310035
Issue: gpuweb/gpuweb#6263
Spec change: gpuweb/gpuweb#6267
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.