chore(npm): enforce min version of node and npm for development#2641
Open
jackw wants to merge 1 commit into
Open
chore(npm): enforce min version of node and npm for development#2641jackw wants to merge 1 commit into
jackw wants to merge 1 commit into
Conversation
Contributor
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens local-development safeguards by enforcing minimum Node.js and npm versions (to ensure .npmrc features like allow-git and min-release-age are actually honored) and by enabling strict engine enforcement via npm.
Changes:
- Raise the repository Node.js engine requirement to
>=24.15and add an npm engine requirement>=11.12. - Enable
engine-strict=truein.npmrcso installs fail fast on unsupported Node/npm versions. - Synchronize the lockfile’s top-level
enginesmetadata withpackage.json.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates engines to require Node >=24.15 and npm >=11.12. |
| package-lock.json | Mirrors the root engines requirements for consistency. |
| .npmrc | Enables engine-strict to enforce the declared engine constraints during installs. |
hugohaggmark
approved these changes
May 20, 2026
sunker
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds a safe guard for local development to the repo by forcing developers to use a version of node and npm for local development that takes advantage of the .npmrc settings
allow-gitandmin-release-age.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: