Skip to content

chore(npm): enforce min version of node and npm for development#2641

Open
jackw wants to merge 1 commit into
mainfrom
jackw/force-npm
Open

chore(npm): enforce min version of node and npm for development#2641
jackw wants to merge 1 commit into
mainfrom
jackw/force-npm

Conversation

@jackw
Copy link
Copy Markdown
Collaborator

@jackw jackw commented May 20, 2026

What this PR does / why we need it:
This adds a safe guard for local development to the repo by forcing developers to use a version of node and npm for local development that takes advantage of the .npmrc settings allow-git and min-release-age.

image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw self-assigned this May 20, 2026
Copilot AI review requested due to automatic review settings May 20, 2026 10:26
@jackw jackw added chore Other changes that don't modify src or test files no-changelog Don't include in changelog and version calculations labels May 20, 2026
@jackw jackw requested review from a team as code owners May 20, 2026 10:26
@jackw jackw requested review from Ukochka, academo, hugohaggmark, joshhunt and wbrowne and removed request for a team May 20, 2026 10:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens local-development safeguards by enforcing minimum Node.js and npm versions (to ensure .npmrc features like allow-git and min-release-age are actually honored) and by enabling strict engine enforcement via npm.

Changes:

  • Raise the repository Node.js engine requirement to >=24.15 and add an npm engine requirement >=11.12.
  • Enable engine-strict=true in .npmrc so installs fail fast on unsupported Node/npm versions.
  • Synchronize the lockfile’s top-level engines metadata with package.json.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Updates engines to require Node >=24.15 and npm >=11.12.
package-lock.json Mirrors the root engines requirements for consistency.
.npmrc Enables engine-strict to enforce the declared engine constraints during installs.

@jackw jackw changed the title chore(npm): use engines.npm and engine-strict chore(npm): enforce min version of node and npm for development May 20, 2026
@github-project-automation github-project-automation Bot moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Other changes that don't modify src or test files no-changelog Don't include in changelog and version calculations

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

4 participants