Interceptor executor safeguard#12736
Closed
kannanjgithub wants to merge 5 commits intogrpc:masterfrom
Closed
Conversation
Contributor
Author
|
I think we can just inline the wrapping for the executor in the filter code itself. If we don't try to use SerializeReentrantCallsDirectExecutor for direct executor (and this class is package private in io.grpc.internal) there is just the passing of the executor to the constructor of SerializingExecutor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the executor lifecycle problem in exposing channel executor as a fallback to CallOptions.getExecutor() to interceptor, mentioned in issue #7868, by safeguarding the
ClientCallcreation withSerializingExecutororSerializeReentrantCallsDirectExecutorat all call sites.Internal: go/safeguarding-channel-executor-for-interceptor